Feature Extension Re: #1360: Option to set default overall zoom for all servers #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker switch has a subtitle associated with it that I don'tk now how to move so this makes more sense.
coxtrent
changed the title
|
Thanks for the work here! Please clean up your commit history and post again to request a review. See here for guidelines. A link to the chat.zulip.org discussion from this PR's description would also be helpful. |
|
Sure! I noticed a couple minor kinks in my implementation so I've been taking a bit more time to work on it. Thanks for the pointers by the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do? Resolves issue #1360 by adding option to synchronize zoom factor across all organizations. Beforehand, the zoom was per organization, making for something of a clunky and sometimes confusing experience.
Any background context you want to provide?
ipcto send a message that synchronizes the zoom factors to 1 when the button is turned on, added "sync-zooms" totype MainMessageandtype RendererMessagein typed-ipc.tsgetZoomFactor()andsetZoomFactor()methods to WebView. in app.renderer.js.components.webview.ts (breaking the abstraction is bad)syncZooms()to ServerManagerView that actually sets the values of all tabs' zoom factors to its one argument (default = 1), then call this function from the WebviewListeners for zoom functions. It must be handled here and not from the BrowserWindow object or else it will change the size of the sidebar with the organizations and settings, etc. The function has no effect if the option is off. This handles the synchronous zoom functionality and optionality almost completely outside the old functions while not changing pre-existing code.You have tested this PR on: